This revision was automatically updated to reflect the committed changes.
Closed by commit rL297779: [clangd] Fix not being able to attach a debugger on
macOS (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D30675?vs=91246&id=91768#toc
Repository:
rL LLVM
https://review
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D30675#700917, @bkramer wrote:
> lg, do you have commit access?
No I do not have commit access. Could you commit it? Thank you very much!
https://reviews.llvm.org/D30675
___
cfe-comm
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg, do you have commit access?
https://reviews.llvm.org/D30675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
malaperle-ericsson added a comment.
Ping :)
https://reviews.llvm.org/D30675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson updated this revision to Diff 91246.
malaperle-ericsson added a comment.
Remove ifdexf
https://reviews.llvm.org/D30675
Files:
clangd/ClangDMain.cpp
Index: clangd/ClangDMain.cpp
===
--- clangd/ClangDMain.cpp
+
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D30675#695370, @bkramer wrote:
> Generally makes sense. Is there any reason for the #ifdef? Windows has errno
> and EINTR too.
I have no reasonable expectation that getline will produce a EINTR on Windows.
But perhaps there's no
bkramer added a comment.
Generally makes sense. Is there any reason for the #ifdef? Windows has errno
and EINTR too.
Repository:
rL LLVM
https://reviews.llvm.org/D30675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
