[PATCH] D30592: [clang-tidy] Fix diag message for catch-by-value

2017-03-23 Thread Alexander Kornienko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL298608: [clang-tidy] Fix diag message for catch-by-value (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D30592?vs=90572&id=92805#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D30592: [clang-tidy] Fix diag message for catch-by-value

2017-03-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D30592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D30592: [clang-tidy] Fix diag message for catch-by-value

2017-03-04 Thread Florian Gross via Phabricator via cfe-commits
fgross updated this revision to Diff 90572. fgross added a comment. Updated test case. https://reviews.llvm.org/D30592 Files: clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp test/clang-tidy/misc-throw-by-value-catch-by-reference.cpp Index: test/clang-tidy/misc-throw-by-value-catch-b

[PATCH] D30592: [clang-tidy] Fix diag message for catch-by-value

2017-03-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. This change is missing test cases. https://reviews.llvm.org/D30592 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D30592: [clang-tidy] Fix diag message for catch-by-value

2017-03-03 Thread Florian Gross via Phabricator via cfe-commits
fgross created this revision. Herald added a subscriber: JDevlieghere. catch (std::exception ex) { } Was flagged with "catch handler catches a pointer value". https://reviews.llvm.org/D30592 Files: clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp Index: clang-tidy/misc/ThrowByVa