[PATCH] D30591: Introduce the feature "linux" for tests only for linux

2017-03-03 Thread Taewook Oh via Phabricator via cfe-commits
twoh abandoned this revision. twoh added a comment. @inglorion That makes a lot of sense. Maybe we don't even need -g, because -S -emit-llvm shows source_filename. I'll run some more experiments with relpath/abspath and debug locations, and submit a revised patch. Thanks for the comment! http

[PATCH] D30591: Introduce the feature "linux" for tests only for linux

2017-03-03 Thread Bob Haarman via Phabricator via cfe-commits
inglorion added a comment. Checking for linux when really you want to check for ELF doesn't seem right. In this case, I think there is an better way to do it; instead of relying on llvm-objdump, could you emit an LLVM assembly file and check that for presence of the string you want? I think if

[PATCH] D30591: Introduce the feature "linux" for tests only for linux

2017-03-03 Thread Taewook Oh via Phabricator via cfe-commits
twoh created this revision. This feature is needed to re-enable https://reviews.llvm.org/rL293004, which resembles gcc's behavior in finding the input file name from a preprocessed source. The patch has been reverted in https://reviews.llvm.org/rL293032, because the test checks FILE symbol of EL