[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

2017-03-23 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. In https://reviews.llvm.org/D30567#708797, @alexfh wrote: > Do you have commit rights? Yes, I will commit this ASAP. https://reviews.llvm.org/D30567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

2017-03-23 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Do you have commit rights? https://reviews.llvm.org/D30567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

2017-03-23 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius updated this revision to Diff 92772. curdeius added a comment. Trim spaces only everywhere. Fix test. https://reviews.llvm.org/D30567 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp Index: unittests/clang-tidy/ClangTidyDia

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

2017-03-22 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:133 + StringRef UntrimmedGlob = GlobList.substr(0, GlobList.find(',')); + StringRef Glob = UntrimmedGlob.trim(); + GlobList = GlobList.substr(UntrimmedGlob.size() + 1); s/trim

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

2017-03-22 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. There's one more trim() you missed. And the test needs to be updated (`s/\\n/ /`). https://reviews.llvm.org/D30567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

2017-03-22 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. Hi Alex, is it OK now? https://reviews.llvm.org/D30567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

2017-03-22 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius updated this revision to Diff 92630. curdeius added a comment. Trim only spaces. https://reviews.llvm.org/D30567 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp Index: unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.c

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

2017-03-22 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In https://reviews.llvm.org/D30567#696436, @curdeius wrote: > Hi Alex and sorry for the late reply. > > The main use case is a more readable `.clang-tidy` configuration checks. > Before this correction one can use something like this: > > --- > Checks: ' > ,*, >

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

2017-03-09 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. Hi Alex and sorry for the late reply. The main use case is a more readable `.clang-tidy` configuration checks. Before this correction one can use something like this: --- Checks: ' ,*, ,-cert-dcl03-c, ' ... It works, but is hardly comprehensible to

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

2017-03-03 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. What's the practical use of newlines and tab characters in the glob list? https://reviews.llvm.org/D30567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits