This revision was automatically updated to reflect the committed changes.
Closed by commit rL296864: [clang-tidy] Format code around applied fixes
(authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D30564?vs=90452&id=90453#toc
Repository:
rL LLVM
https://reviews.llvm.or
alexfh updated this revision to Diff 90452.
alexfh added a comment.
Apply changes even when formatting fails.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/clean-up-code
ioeric added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:214
+ llvm::errs() << llvm::toString(Replacements.takeError()) << "\n";
+ continue;
+}
Maybe still apply the replacements if formatting fails?
https://reviews.llvm.org/
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
https://reviews.llvm.org/D30564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
malcolm.parsons added a comment.
LGTM.
https://reviews.llvm.org/D30564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
PTAL
https://reviews.llvm.org/D30564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh updated this revision to Diff 90448.
alexfh added a comment.
Clarify the 'file' option a bit.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/clean-up-code.cpp
te
alexfh added a comment.
In https://reviews.llvm.org/D30564#691446, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D30564#691441, @alexfh wrote:
>
> > Replace the separate -format and -style options with -format-style (default
> > is
> > 'none', which means no formatting).
>
>
> Is there
alexfh updated this revision to Diff 90447.
alexfh added a comment.
Expanded -format-style option description. Run cleanup tests with different
format styles, just in case.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes
malcolm.parsons added a comment.
In https://reviews.llvm.org/D30564#691441, @alexfh wrote:
> Replace the separate -format and -style options with -format-style (default is
> 'none', which means no formatting).
Is there a style that means use my .clang-format file?
https://reviews.llvm.org/D3
alexfh updated this revision to Diff 90445.
alexfh marked an inline comment as done.
alexfh added a comment.
Replace the separate -format and -style options with -format-style (default is
'none', which means no formatting).
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
cla
ioeric added inline comments.
Comment at: test/clang-tidy/readability-braces-around-statements-format.cpp:1
+// RUN: %check_clang_tidy %s readability-braces-around-statements %t --
-format --
+
alexfh wrote:
> malcolm.parsons wrote:
> > Will clang-tidy look for
alexfh marked an inline comment as done.
alexfh added inline comments.
Comment at: docs/clang-tidy/index.rst:184
-p= - Build path
+-quiet -
+ Run clang-tidy in quiet mode. This
suppresses
-
kimgr added inline comments.
Comment at: docs/clang-tidy/index.rst:184
-p= - Build path
+-quiet -
+ Run clang-tidy in quiet mode. This
suppresses
This looks like a separate patch?
alexfh added inline comments.
Comment at: test/clang-tidy/readability-braces-around-statements-format.cpp:1
+// RUN: %check_clang_tidy %s readability-braces-around-statements %t --
-format --
+
malcolm.parsons wrote:
> Will clang-tidy look for a .clang-format fi
alexfh updated this revision to Diff 90442.
alexfh added a comment.
Pacify llvm::Expected<> debug checks.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/cla
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/readability-braces-around-statements-format.cpp:1
+// RUN: %check_clang_tidy %s readability-braces-around-statements %t --
-format --
+
Will clang-tidy look for a .clang-format file?
Does this te
alexfh created this revision.
Herald added a subscriber: JDevlieghere.
Add -format option (disabled by default for now) to trigger formatting
of replacements.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
docs/Re
18 matches
Mail list logo
