[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

2017-03-09 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL297436: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D30551?vs=90520&id=91243#toc Repository: rL LLVM https://re

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

2017-03-08 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D30551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

2017-03-03 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 90520. yaxunl marked 3 inline comments as done. yaxunl added a comment. remove redundant code. make mov_dpp target builtin. https://reviews.llvm.org/D30551 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/Basic/Targets.cpp lib/CodeGen/CGBuiltin.cpp

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

2017-03-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 90399. yaxunl added a comment. Make some arguments constant. https://reviews.llvm.org/D30551 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-amdgcn.cl test/SemaOpenCL/builtins-amdgcn-error.cl Index

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

2017-03-02 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In https://reviews.llvm.org/D30551#691149, @b-sumner wrote: > mov_dpp should be under the VI+ comment Also should be made to use TARGET_BUILTIN and dependent on dpp feature https://reviews.llvm.org/D30551 ___ cfe-commits m

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

2017-03-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8391-8398 + case AMDGPU::BI__builtin_amdgcn_ds_permute: +return emitBinaryBuiltin(*this, E, Intrinsic::amdgcn_ds_permute); + case AMDGPU::BI__builtin_amdgcn_ds_bpermute: +return emitBinaryBuiltin(*this,

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

2017-03-02 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8391-8398 + case AMDGPU::BI__builtin_amdgcn_ds_permute: +return emitBinaryBuiltin(*this, E, Intrinsic::amdgcn_ds_permute); + case AMDGPU::BI__builtin_amdgcn_ds_bpermute: +return emitBinaryBuiltin(*this,

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

2017-03-02 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner added a comment. mov_dpp should be under the VI+ comment https://reviews.llvm.org/D30551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

2017-03-02 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8391-8398 + case AMDGPU::BI__builtin_amdgcn_ds_permute: +return emitBinaryBuiltin(*this, E, Intrinsic::amdgcn_ds_permute); + case AMDGPU::BI__builtin_amdgcn_ds_bpermute: +return emitBinaryBuiltin(*this,

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

2017-03-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. Herald added subscribers: tpr, dstuttard, tony-tye, nhaehnle, wdng, kzhuravl. https://reviews.llvm.org/D30551 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-amdgcn.cl Index: test/CodeGenOpenCL/builtins-amdg