This revision was automatically updated to reflect the committed changes.
Closed by commit rL296636: [clangd] Add support for FixIts. (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D30498?vs=90181&id=90187#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30498
Files:
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks Great!
https://reviews.llvm.org/D30498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
bkramer updated this revision to Diff 90181.
bkramer added a comment.
- Use typedef instead of decltype()
- Rename local variable not to shadow member.
- Give FixIts their own mutex
- Use const instead of let in typescript
https://reviews.llvm.org/D30498
Files:
clangd/ASTManager.cpp
clangd/
krasimir added inline comments.
Comment at: clangd/ASTManager.cpp:105
+ std::string Diagnostics;
+ decltype(this->FixIts) LocalFixIts; // Temporary storage
+ for (ASTUnit::stored_diag_iterator D = Unit->stored_diag_begin(),
Why not typedef the type of the FixI
bkramer created this revision.
This uses CodeActions to show 'apply fix' actions when code actions are
requested for a location. The actions themselves make use of a
clangd.applyFix command which has to be implemented on the editor side. I
included an implementation for vscode.
This also adds a -
