[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

2017-02-27 Thread Ranjeet Singh via Phabricator via cfe-commits
rs added a comment. > This works for me, but the idiomatic macro usage in libc++, and (hopefully) > libc++abi should always use !defined(FOO) as opposed to !FOO. I'll clean this > up in the next week if nobody else wants to. I can do the clean up later this week. Repository: rL LLVM https:

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

2017-02-24 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. This works for me, but the idiomatic macro usage in libc++, and (hopefully) libc++abi should always use `defined(FOO)` as opposed to `!FOO`. I'll clean this up in the next week if nobody else wants to. Repository: rL LLVM https://reviews.llvm.org/D30343 __

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

2017-02-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL296146: [libcxxabi] Fix condition typo in rL296136 (authored by rsingh). Changed prior to commit: https://reviews.llvm.org/D30343?vs=89687&id=89693#toc Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

2017-02-24 Thread Ranjeet Singh via Phabricator via cfe-commits
rs added a comment. Going for post-commit. https://reviews.llvm.org/D30343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

2017-02-24 Thread Ranjeet Singh via Phabricator via cfe-commits
rs created this revision. Made a mistake in the condition typo because LIBCXXABI_BAREMETAL is always defined, I should have been checking the contents to see if it's enabled https://reviews.llvm.org/D30343 Files: src/abort_message.cpp Index: src/abort_message.cpp ==