arsenm closed this revision.
arsenm added a comment.
r297658, r297659
https://reviews.llvm.org/D30316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added a comment.
In https://reviews.llvm.org/D30316#686174, @yaxunl wrote:
> AMDGPUTargetMachine::getNullPointerValue needs also be changed to match
> this, otherwise the static initializer will be incorrect for null pointer to
> private addr space. Do you plan to change that?
Yes, t
yaxunl added a comment.
AMDGPUTargetMachine::getNullPointerValue needs also be changed to match this,
otherwise the static initializer will be incorrect for null pointer to private
addr space. Do you plan to change that?
https://reviews.llvm.org/D30316
__
arsenm added a comment.
In https://reviews.llvm.org/D30316#686089, @yaxunl wrote:
> LGTM. Thanks! I assume you will make corresponding changes in backend.
This is to match r295891, so then https://reviews.llvm.org/D28937 is required
to fix addrspacecast
https://reviews.llvm.org/D30316
___
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks! I assume you will make corresponding changes in backend.
https://reviews.llvm.org/D30316
___
cfe-commits mailing list
cfe-commits@l
arsenm created this revision.
Herald added subscribers: tpr, dstuttard, tony-tye, nhaehnle, wdng, kzhuravl.
https://reviews.llvm.org/D30316
Files:
lib/Basic/Targets.cpp
test/CodeGenOpenCL/amdgpu-nullptr.cl
Index: test/CodeGenOpenCL/amdgpu-nullptr.cl
==
