[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-03-08 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL297276: Honor __unaligned in codegen for declarations and expressions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D30166?vs=89989&id=91005#toc Repository: rL LLVM https

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-03-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. Looks good! Sorry for the delay, I was out last week. https://reviews.llvm.org/D30166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-03-07 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 added a comment. Ping? :-) Kind regards https://reviews.llvm.org/D30166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-02-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this LGTM, but you should wait for confirmation from one of the other reviewers before committing. https://reviews.llvm.org/D30166 ___

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-02-28 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 updated this revision to Diff 89989. rogfer01 added a comment. Avoid altering results of TypeInfo due to the __unaligned qualifier. Instead override the natural alignment to 1 if the type is __unaligned-qualified. https://reviews.llvm.org/D30166 Files: lib/AST/ASTContext.cpp lib/A

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-02-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: majnemer. aaron.ballman added inline comments. Comment at: include/clang/AST/ASTContext.h:1909 +// the unqualified type. +if (T.getQualifiers().hasUnaligned()) + TI.Align = getCharWidth(); This makes me a bit uncomfort

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-02-27 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 added a comment. Ping? :-) Kind regards https://reviews.llvm.org/D30166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-02-21 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 updated this revision to Diff 89172. rogfer01 marked 2 inline comments as done. rogfer01 added a comment. Updated patch. Use TargetInfo::getCharWidth and remove unnecessary else. https://reviews.llvm.org/D30166 Files: include/clang/AST/ASTContext.h lib/AST/ASTContext.cpp lib/AST/

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-02-20 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added inline comments. Comment at: include/clang/AST/ASTContext.h:1910 +if (T.getQualifiers().hasUnaligned()) + TI.Align = 8; +return TI; Is it better to call TargetInfo::getCharWidth() instead of assigning a hardcoded number here? ==

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-02-20 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 created this revision. See related proposal in http://lists.llvm.org/pipermail/cfe-dev/2017-February/052739.html This patch honors the unaligned type qualifier (currently available through he keyword __unaligned and -fms-extensions) in CodeGen. In the current form the patch affects de