hiraditya abandoned this revision.
hiraditya added a comment.
Merged with https://reviews.llvm.org/D30268
https://reviews.llvm.org/D30035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
hiraditya added a comment.
Thank you for the feedback. This was supposed to be first out of two patches. I
have posted the next patch here: https://reviews.llvm.org/D30268 which aims to
remove copy of __src array each time a number is parsed. I can abandon this
patch if we don't need to separat
Adding const to pointed/referenced types doesn't usually help the compiler,
since they don't guarantee that the underlying object is const (nor that
any use can't involve const_casting away the constness and mutating the
value anyway).
On Fri, Feb 17, 2017 at 2:34 PM Aditya Kumar via Phabricator v
mclow.lists added a comment.
Absent I good motivation (i.e, a documented, significant performance change), I
don't think we want this - not because it's not a reasonable change (it is!),
but because it's an ABI break.
It's unfortunate the `__atoms` were not passed as const in the first place.
A
hiraditya added a comment.
Adding const could help compiler, I do not have any specific performance
numbers yet. So if this is too much trouble then we don't have to merge this.
https://reviews.llvm.org/D30035
___
cfe-commits mailing list
cfe-commi
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
This change is ABI breaking because these functions are exported using explicit
template instantiations, and because changing their signature changes the
mangling.
Can you explain w
sebpop added a comment.
Looks good to me.
https://reviews.llvm.org/D30035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya created this revision.
https://reviews.llvm.org/D30035
Files:
include/locale
Index: include/locale
===
--- include/locale
+++ include/locale
@@ -385,12 +385,12 @@
_CharT& __thousan
