[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-20 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r295683 https://reviews.llvm.org/D29967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-17 Thread David Herzka via Phabricator via cfe-commits
herzka added a comment. @compnerd, yes please. I don't have commit access. Thanks for the review! https://reviews.llvm.org/D29967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-17 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Ah, I had missed the `-verify` option on the test. Yes, that makes sense. Ternary may have flowed the conditional code better. Do you need someone to commit this on your behalf? https

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-16 Thread David Herzka via Phabricator via cfe-commits
herzka added a comment. Currently, `A.customGetterProperty` would be turned into `[A customGetterProperty]`, which would fail to compile because that selector isn't declared anywhere. With my fix, it does compile because it (correctly) resolves to `[A customGet]`, which does exist. Similarly, `

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-16 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. I think Im misunderstanding something. How does the test actually test what you are changing? https://reviews.llvm.org/D29967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-15 Thread David Herzka via Phabricator via cfe-commits
herzka updated this revision to Diff 88652. herzka added a comment. Rename selectors https://reviews.llvm.org/D29967 Files: lib/Sema/SemaExprObjC.cpp test/SemaObjC/objc-class-property.m Index: test/SemaObjC/objc-class-property.m

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-15 Thread David Herzka via Phabricator via cfe-commits
herzka updated this revision to Diff 88650. herzka added a comment. Added test, used auto https://reviews.llvm.org/D29967 Files: lib/Sema/SemaExprObjC.cpp test/SemaObjC/objc-class-property.m Index: test/SemaObjC/objc-class-property.m ===

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-15 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Please add a test for this. Comment at: lib/Sema/SemaExprObjC.cpp:1989 + Selector SetterSel; + if (ObjCPropertyDecl *PD = IFace->FindPropertyDeclaration( +

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-15 Thread David Herzka via Phabricator via cfe-commits
herzka updated this revision to Diff 88519. herzka edited the summary of this revision. herzka added a comment. Added full context. Sorry about that! This is my first contribution, and I don't know how I completely missed that line while going through the steps. https://reviews.llvm.org/D29967

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-14 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Can you please post the patch with full context (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)? https://reviews.llvm.org/D29967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-14 Thread David Herzka via Phabricator via cfe-commits
herzka updated this revision to Diff 88448. herzka retitled this revision from "Get class property setter selector from property decl if exists" to "Get class property selectors from property decl if it exists". herzka edited the summary of this revision. https://reviews.llvm.org/D29967 Files: