[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

dylanmckay added a comment. Done, thanks for the patch @Lekensteyn! If you plan on submitting more patches, feel free to ask for commit access . Repository: rL LLVM https://reviews.llvm.org/D29817

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rL294869: [AVR] Fix __AVR_xxx macro definitions; authored by Peter Wu (authored by dylanmckay). Changed prior to commit: https://reviews.llvm.org/D29817?vs=88025&id=88104#toc Repository: rL LLVM https

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

Lekensteyn added a comment. In https://reviews.llvm.org/D29817#674306, @dylanmckay wrote: > Do you have commit access @Lekensteyn? No I do not, please push it for me :-) https://reviews.llvm.org/D29817 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

dylanmckay added a comment. Do you have commit access @Lekensteyn? https://reviews.llvm.org/D29817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

Lekensteyn updated this revision to Diff 88025. Lekensteyn marked an inline comment as done. Lekensteyn added a comment. Good catch! I just checked again and confirmed that there is only one line that had this issue (there are no other occurrences of `___"`). https://reviews.llvm.org/D29817 Fi

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

efriedma added inline comments. Comment at: lib/Basic/Targets.cpp:8464 static ArrayRef AVRMcus = { - { "at90s1200", "__AVR_AT90S1200__" }, - { "attiny11", "__AVR_ATtiny11" }, - { "attiny12", "__AVR_ATtiny12" }, - { "attiny15", "__AVR_ATtiny15" }, - { "attiny28", "__AVR_ATti

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D29817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

Lekensteyn updated this revision to Diff 87986. Lekensteyn added a comment. Oops, missed the avrtiny patch. After updating that, it now actually passes the clang-test tests. https://reviews.llvm.org/D29817 Files: lib/Basic/Targets.cpp test/CodeGen/avr/target-cpu-defines/atmega328p.c test

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

dylanmckay added a comment. Nice catch, unsure why I didn't catch this earlier. Do we also need to modify the other tests inside `target-cpu-defines`? https://reviews.llvm.org/D29817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D29817: [AVR} Fix __AVR_xxx macro definitions

Lekensteyn added a comment. Without this patch, compilation of a program using avr/io.h fails. Tested with: clang --target=avr -Xclang -target-cpu -Xclang atmega328p -I/usr/avr/include -Os led.c -c -o /dev/null Btw, it seems that avr-libc 2.0.0 also uses `__AVR_ARCH__`, `__AVR_XMEGA__` and `

[PATCH] D29817: [AVR} Fix __AVR_xxx macro definitions

Lekensteyn created this revision. The -mmcu option for GCC sets macros like __AVR_ATmega328P__ (with the trailing underscores), be sure to include these underscores for Clangs -mcpu option. See "AVR Built-in Macros" in https://gcc.gnu.org/onlinedocs/gcc/AVR-Options.html https://reviews.llvm.org