This revision was automatically updated to reflect the committed changes.
Closed by commit rL295482: [clang-tidy] Add -path option to clang-tidy-diff.py
(authored by ehsan).
Changed prior to commit:
https://reviews.llvm.org/D29806?vs=88879&id=88959#toc
Repository:
rL LLVM
https://reviews.ll
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ehsan updated this revision to Diff 88879.
ehsan added a comment.
Addressed the review comments.
https://reviews.llvm.org/D29806
Files:
clang-tidy/tool/clang-tidy-diff.py
test/clang-tidy/clang-tidy-diff.cpp
Index: test/clang-tidy/clang-tidy-diff.cpp
===
alexfh added a comment.
In https://reviews.llvm.org/D29806#673489, @ehsan wrote:
> In https://reviews.llvm.org/D29806#673329, @alexfh wrote:
>
> > What's your use case? Can it be addressed by just forwarding the -p flag to
> > clang-tidy?
>
>
> I just need to pass the full path to the compilatio
ehsan added a comment.
Gentle ping. :-)
https://reviews.llvm.org/D29806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ehsan added a comment.
In https://reviews.llvm.org/D29806#673329, @alexfh wrote:
> What's your use case? Can it be addressed by just forwarding the -p flag to
> clang-tidy?
I just need to pass the full path to the compilation DB to clang-tidy. The
problem is that invoking `clang-tidy-diff.py
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
What's your use case? Can it be addressed by just forwarding the -p flag to
clang-tidy?
The script shouldn't know anything about implementation details of the
compilation database b
ehsan created this revision.
Herald added a subscriber: JDevlieghere.
This flag allows specifying a custom path for the compilation
database. Unfortunately we can't use the -p flag like other
clang-tidy tools because it's already taken.
https://reviews.llvm.org/D29806
Files:
clang-tidy/tool/
