[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

2017-02-20 Thread Sanne Wouda via Phabricator via cfe-commits
sanwou01 abandoned this revision. sanwou01 added a comment. Please see https://reviews.llvm.org/D30167 for an attempt to test this from llc. https://reviews.llvm.org/D29770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

2017-02-13 Thread Jim Grosbach via Phabricator via cfe-commits
grosbach added a comment. Eric is correct. These tests would be more suitable in llc. The clang tests should check that the inline asm is inserted into the IR in the correct form if there's any difference pre and post patch (I don't think there is?). https://reviews.llvm.org/D29770

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

2017-02-13 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. In https://reviews.llvm.org/D29770#674961, @sanwou01 wrote: > Use clang_cc1 -verify for testing as suggested by @rnk. > > @echristo, llc does use the same diags interfaces as clang, however, it is > lacking the infrastructure to make use of LocCookies. > > In any case,

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

2017-02-13 Thread Sanne Wouda via Phabricator via cfe-commits
sanwou01 updated this revision to Diff 88188. sanwou01 added a comment. Use clang_cc1 -verify for testing as suggested by @rnk. @echristo, llc does use the same diags interfaces as clang, however, it is lacking the infrastructure to make use of LocCookies. In any case, I think this test is usefu

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

2017-02-09 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. Can we not get llc to use the diags interfaces here? https://reviews.llvm.org/D29770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

2017-02-09 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: test/Misc/inline-asm-diags.c:1 +// RUN: not %clang -c --target=armv7a-arm-none-eabi %s -o /dev/null 2>&1 | FileCheck %s + Use `clang -cc1 -S -o /dev/null -verify` to test this. https://reviews.llvm.org/D29770 _

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

2017-02-09 Thread Sanne Wouda via Phabricator via cfe-commits
sanwou01 added a comment. This tests the improved inline asm diagnostics from https://reviews.llvm.org/D29769. https://reviews.llvm.org/D29770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

2017-02-09 Thread Sanne Wouda via Phabricator via cfe-commits
sanwou01 created this revision. Add a test for improved inline assembly diagnostics in llvm. https://reviews.llvm.org/D29770 Files: test/Misc/inline-asm-diags.c Index: test/Misc/inline-asm-diags.c === --- /dev/null +++ test/Mis