This revision was automatically updated to reflect the committed changes.
Closed by commit rL295319: [OpenMP] Parallel reduction on the NVPTX device.
(authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29758?vs=88149&id=88726#toc
Repository:
rL LLVM
https://reviews.llvm
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
arpith-jacob updated this revision to Diff 88149.
arpith-jacob added a comment.
Minor fixup of comment style on emitInterWarpCopyFunction().
https://reviews.llvm.org/D29758
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/Code
arpith-jacob updated this revision to Diff 88144.
arpith-jacob added a comment.
Updated patch to address Alexey's comments. Condensed parameters in
emitReduction() to a struct Options.
https://reviews.llvm.org/D29758
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
l
Arpith, see the comment in CGOpenMPRuntime.cpp
// if SimpleReduction is true, only the next code is generated:
// ...
// [i] = RedOp(*[i], *[i]);
// ...
and is used for omp simd directive only.
-
Best regards,
Alexey Bataev
10.02.2017 18:49, Arpith Jacob via Phabricat
arpith-jacob added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:956-962
virtual void emitReduction(CodeGenFunction &CGF, SourceLocation Loc,
ArrayRef Privates,
ArrayRef LHSExprs,
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:956-962
virtual void emitReduction(CodeGenFunction &CGF, SourceLocation Loc,
ArrayRef Privates,
ArrayRef LHSExprs,
arpith-jacob created this revision.
Herald added a subscriber: jholewinski.
This patch implements codegen for the reduction clause on
any parallel construct for elementary data types. An efficient
implementation requires hierarchical reduction within a
warp and a threadblock. It is complicated b