[PATCH] D29506: [OpenMP] Teams reduction on the NVPTX device.

2017-02-09 Thread Arpith Jacob via Phabricator via cfe-commits
arpith-jacob marked 2 inline comments as done. arpith-jacob added a comment. In https://reviews.llvm.org/D29506#669542, @ABataev wrote: > The patch is too big and quite hard to review? Could you split it into > several smaller parts? Alexey, thank you for your time. I have addressed your comm

[PATCH] D29506: [OpenMP] Teams reduction on the NVPTX device.

2017-02-07 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. The patch is too big and quite hard to review? Could you split it into several smaller parts? Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4280-4282 + // We don't need debug information in this function as nothing here refers to + // user source code.

[PATCH] D29506: [OpenMP] Teams reduction on the NVPTX device.

2017-02-03 Thread Arpith Jacob via Phabricator via cfe-commits
arpith-jacob added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:524 + + static bool classof(const CGOpenMPRuntime *RT) { +return RT->getKind() == RK_HOST; This is required to cast to the NVPTX runtime in a static function as follows; CGOpenMPR