[PATCH] D29432: Modular Codegen: Emit inline asm into users, not modular objects

2017-02-13 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. +rsmith we chatted about a bit of this offline & some things came out of it, not entirely resolved: 1. Is this the right thing for inline asm or similar things (static functions? static variables?) - I was mirroring the choice already made for static variables (motiva

[PATCH] D29432: Modular Codegen: Emit inline asm into users, not modular objects

2017-02-01 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Oh, one of the reasons I was sort of compelled to keep the 'classic' AST file compilation working was that when looking at the change history of the test cases exercising it I found that some changes had been motivated by a filed LLVM bug: https://llvm.org/bugs/show_bu

[PATCH] D29432: Modular Codegen: Emit inline asm into users, not modular objects

2017-02-01 Thread David Blaikie via Phabricator via cfe-commits
dblaikie created this revision. The best semantics I can come up with (based on discussions with Richard) for inline asm and namespace scope internal linkage variables in modular headers is to emit them into all users and never into modular objects. The reason for this is that such asm might crea