baloghadamsoftware abandoned this revision.
baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added a comment.
Superseeded by patch https://reviews.llvm.org/D31975.
https://reviews.llvm.org/D29419
___
cfe-commits mailing list
c
zaks.anna added a comment.
> So it would be a wast of resources to duplicate these data. So now I am
> also working on the merged version.
Would it make sense to just resume the review on the merged patch?
https://reviews.llvm.org/D29419
___
cfe
hiraditya added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MismatchedIteratorChecker.cpp:375
+ "MismatchedIterator");
+auto *N = C.generateNonFatalErrorNode(State, &Tag);
+if (!N) {
This can be rewritten
baloghadamsoftware marked 2 inline comments as done.
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MismatchedIteratorChecker.cpp:311
+
+void MismatchedIteratorChecker::checkPostStmt(const DeclStmt *DS,
+
baloghadamsoftware updated this revision to Diff 89123.
baloghadamsoftware added a comment.
Updated according to the comments.
https://reviews.llvm.org/D29419
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/Mi
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D29419#671839, @NoQ wrote:
> This one looks similar to the `IteratorPastEnd` checker, so much that i'd
> definitely advice re-using some code. At the very least, functions like
> `isIterator()` should definitely deserve a header so
NoQ added a comment.
Hello, thanks for another useful checker! I make quite a few of these mistakes
regularly.
This one looks similar to the `IteratorPastEnd` checker, so much that i'd
definitely advice re-using some code. At the very least, functions like
`isIterator()` should definitely dese
baloghadamsoftware updated this revision to Diff 86709.
baloghadamsoftware added a comment.
Herald added a subscriber: mgorny.
The checker itself disappeared mystically from the previous diff...
https://reviews.llvm.org/D29419
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/Sta
baloghadamsoftware created this revision.
A new checker to check whether multiple iterators which should refer to the
same container refer to different ones. Here we include comparisons,
constructors which take an iterator pair and any template function which takes
iterator pair(s).
https://r
