This revision was automatically updated to reflect the committed changes.
malcolm.parsons marked 4 inline comments as done.
Closed by commit rL295176: [clang-tidy] Don't warn about call to unresolved
operator* (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D293
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a minor nit that can be fixed without further review.
Comment at: test/clang-tidy/misc-unconventional-assign-operator.cpp:92
+enum E { e };
+E operato
idlecode added inline comments.
Comment at: clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp:63
+cxxOperatorCallExpr(argumentCountIs(1),
+callee(unresolvedLookupExpr()),
+hasArgument(0, cxxThisExpr()
malcolm.parsons added inline comments.
Comment at: clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp:63
+cxxOperatorCallExpr(argumentCountIs(1),
+callee(unresolvedLookupExpr()),
+hasArgument(0, cxxThi
idlecode added inline comments.
Comment at: clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp:63
+cxxOperatorCallExpr(argumentCountIs(1),
+callee(unresolvedLookupExpr()),
+hasArgument(0, cxxThisExpr()
malcolm.parsons created this revision.
Herald added a subscriber: JDevlieghere.
The misc-unconventional-assign-operator check had a false positive
warning when the 'operator*' in 'return *this' was unresolved.
Change matcher to allow calls to unresolved operator.
Fixes PR31531.
https://reviews
