This revision was automatically updated to reflect the committed changes.
Closed by commit rL293624: [clang-format] Fix regression merging comments
across newlines. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29322?vs=86412&id=86413#toc
Repository:
rL LLVM
htt
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2127-2129
+// Additional fine-grained breaking of line comment sections is controlled
+// by the class BreakableLineCommentSection in case it is desirable to keep
+// several line comment s
krasimir updated this revision to Diff 86412.
krasimir marked an inline comment as done.
krasimir added a comment.
- Add a FIXME also in the parser
https://reviews.llvm.org/D29322
Files:
lib/Format/BreakableToken.cpp
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTest.cpp
Ind
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg minus adding the FIXME to the place where we need the change.
Comment at: lib/Format/UnwrappedLineParser.cpp:2127-2129
+// Additional fine-grained breaking of line com
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:685
LineTok = CurrentTok->Next;
+if (CurrentTok->Next && CurrentTok->Next->NewlinesBefore > 1) {
+ // A line comment section needs to broken by a lin
krasimir updated this revision to Diff 86410.
krasimir added a comment.
- Add a FIXME for separating line comment sections into child lines
https://reviews.llvm.org/D29322
Files:
lib/Format/BreakableToken.cpp
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTest.cpp
Index: unit
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:685
LineTok = CurrentTok->Next;
+if (CurrentTok->Next && CurrentTok->Next->NewlinesBefore > 1) {
+ // A line comment section needs to broken by a line comment that is
klimek w
klimek added inline comments.
Comment at: lib/Format/BreakableToken.cpp:685
LineTok = CurrentTok->Next;
+if (CurrentTok->Next && CurrentTok->Next->NewlinesBefore > 1) {
+ // A line comment section needs to broken by a line comment that is
Could we p
