This revision was automatically updated to reflect the committed changes.
Closed by commit rL299543: clang-format-vsix: Add "Format on Save" feature
(authored by amaiorano).
Changed prior to commit:
https://reviews.llvm.org/D29221?vs=89815&id=94225#toc
Repository:
rL LLVM
https://reviews.ll
amaiorano added a comment.
In https://reviews.llvm.org/D29221#713902, @hans wrote:
> In https://reviews.llvm.org/D29221#698679, @amaiorano wrote:
>
> > Hey guys, any feedback on this? About 1.5 weeks ago, @hans asked @klimek
> > and @djasper for their opinions on "clang-format" vs "ClangFormat".
hans added a comment.
In https://reviews.llvm.org/D29221#698679, @amaiorano wrote:
> Hey guys, any feedback on this? About 1.5 weeks ago, @hans asked @klimek and
> @djasper for their opinions on "clang-format" vs "ClangFormat". Thanks!
Let's get this committed now and not worry about renaming
amaiorano added a comment.
In https://reviews.llvm.org/D29221#688697, @hans wrote:
> >>> My only nit is that I'd prefer "clang-format" instead of "ClangFormat".
> >>>
> >>> Manuel: the menu options under Tools currently say "Clang Format
> >>> {Selection,Document}". What do you think about usin
hans added a subscriber: djasper.
hans added a comment.
>>> My only nit is that I'd prefer "clang-format" instead of "ClangFormat".
>>>
>>> Manuel: the menu options under Tools currently say "Clang Format
>>> {Selection,Document}". What do you think about using "clang-format" here
>>> instead?
amaiorano added a comment.
In https://reviews.llvm.org/D29221#687438, @amaiorano wrote:
> In https://reviews.llvm.org/D29221#687425, @hans wrote:
>
> > In https://reviews.llvm.org/D29221#686865, @amaiorano wrote:
> >
> > > Made changes based on @hans 's feedback.
> > >
> > > I looked again at the
amaiorano added a comment.
In https://reviews.llvm.org/D29221#687425, @hans wrote:
> In https://reviews.llvm.org/D29221#686865, @amaiorano wrote:
>
> > Made changes based on @hans 's feedback.
> >
> > I looked again at the categories, and I think it makes sense with my
> > changes. Here's an upd
hans added a comment.
In https://reviews.llvm.org/D29221#686865, @amaiorano wrote:
> Made changes based on @hans 's feedback.
>
> I looked again at the categories, and I think it makes sense with my changes.
> Here's an updated screenshot that shows what the options menu in Visual
> Studio look
amaiorano updated this revision to Diff 89815.
amaiorano added a comment.
Made changes based on @hans 's feedback.
I looked again at the categories, and I think it makes sense with my changes.
Here's an updated screenshot that shows what the options menu in Visual Studio
looks like with these c
amaiorano added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:276
+
+if (Vsix.IsDocumentDirty(document))
+{
hans wrote:
> Perhaps return early if `!Vsix.IsDocumentDirty(document)` instead?
Yes, will d
amaiorano added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:39
private string style = "file";
+private bool formatOnSaveEnabled = false;
+private string formatOnSaveFileExtensions =
hans wrote:
> P
hans added a comment.
I'm not really qualified to review the implementation details, but this seems
good as far as I can tell. A few comments, mostly style related.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:39
private string style = "file";
+
amaiorano added a comment.
Hello again. Just wondering if anyone could take a look at this? I updated the
patch a week ago :) Thanks!
https://reviews.llvm.org/D29221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
amaiorano updated this revision to Diff 88000.
amaiorano added a comment.
- Renamed VsixUtils to Vsix and TypeConverterUtils to TypeConversion
- Removed format on save mode
The change is simpler now without the "mode" (current or all documents). Now
I'm wondering whether I should rename the feat
amaiorano added a comment.
In https://reviews.llvm.org/D29221#668867, @klimek wrote:
> +hans
>
> +1 to "format only current document but save all" not making much sense :)
Yes, I've been using this version for a little while now, and it's not useful
to have the current document version. I'll r
klimek added a reviewer: hans.
klimek added a comment.
+hans
+1 to "format only current document but save all" not making much sense :)
Comment at: tools/clang-format-vs/ClangFormat/TypeConverterUtils.cs:7
+{
+public sealed class TypeConverterUtils
+{
amaiorano added a comment.
Hello! Just a small ping to see if anyone has taken a look at this change? I
fully understand that everyone's really busy, but perhaps you can recommend
another reviewer? Or if you're presently giving this change a whirl, just let
me know! Cheers :)
https://reviews.
amaiorano created this revision.
This change adds a feature to the clang-format VS extension that optionally
enables the automatic formatting of documents when saving. Since developers
always need to save their files, this eases the workflow of making sure source
files are properly formatted. T
18 matches
Mail list logo
