This revision was automatically updated to reflect the committed changes.
Closed by commit rL293305: clang-cl: Warn about /U flags that look like
filenames (PR31662) (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D29198?vs=85963&id=86062#toc
Repository:
rL LLVM
https:
compnerd accepted this revision.
compnerd added a comment.
Thanks for adding this, diagnosing what was going on here the first time around
took a little bit of thinking.
https://reviews.llvm.org/D29198
___
cfe-commits mailing list
cfe-commits@lists
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D29198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:252
+ InGroup>;
+def note_use_dashdash : Note<"Use '--' to treat subsequent arguments as
filenames">;
+
amccarth wrote:
> For Windows, wouldn't it make more sense to suggest us
amccarth added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:252
+ InGroup>;
+def note_use_dashdash : Note<"Use '--' to treat subsequent arguments as
filenames">;
+
For Windows, wouldn't it make more sense to suggest using valid path
hans created this revision.
Both on Mac and Windows, it's common to have a 'Users' directory in the root of
the filesystem, so one might specify a filename as '/Users/me/myfile.c'.
clang-cl (as well as MSVC's cl.exe) will interpret that as invoking '/U'
option, which is probably not what the us
