This revision was automatically updated to reflect the committed changes.
Closed by commit rL293270: clang-format: [JS] do not format MPEG transport
streams. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D29186?vs=85934&id=86028#toc
Repository:
rL LLVM
https://rev
mprobst added a comment.
In https://reviews.llvm.org/D29186#657828, @alexeagle wrote:
> confused, wasn't this committed last year? is this an extra check?
I think I fixed this in tslint, but not in clang-format. At least I cannot find
a trace of it (but yeah, I thought I had fixed it, too).
alexeagle added a comment.
confused, wasn't this committed last year? is this an extra check?
https://reviews.llvm.org/D29186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst added a comment.
PTAL, moved the check down a bit.
https://reviews.llvm.org/D29186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst updated this revision to Diff 85934.
mprobst added a comment.
- Move MPEG check into Format.cpp.
https://reviews.llvm.org/D29186
Files:
lib/Format/Format.cpp
tools/clang-format/ClangFormat.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/Format/FormatTestJS.cpp:1002
+TEST_F(FormatTestJS, IgnoresMpegTS) {
+ char mpegTS[200];
+ mpegTS[0] = 0x47;
nit: Should be Mpeg
mprobst created this revision.
Herald added a subscriber: klimek.
The MPEG transport stream file format also uses ".ts" as its file extension.
This change detects its specific framing format (0x47 every 189 bytes) and
simply ignores MPEG TS files.
https://reviews.llvm.org/D29186
Files:
tools/
