Re: [PATCH] D29063: [libcxx] Never use within libc++

2017-01-24 Thread Asiri Rathnayake via cfe-commits
Thanks for the lightening fast response :) / Asiri On Tue, Jan 24, 2017 at 12:38 PM, Eric Fiselier via Phabricator via cfe-commits wrote: > EricWF added a comment. > > It seems like weird usages of `_LIBCPP_ASSERT` in `` are > causing this problem. > Specifically the usages in `` attempt to use

[PATCH] D29063: [libcxx] Never use within libc++

2017-01-24 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. It seems like weird usages of `_LIBCPP_ASSERT` in `` are causing this problem. Specifically the usages in `` attempt to use `_LIBCPP_ASSERT` in C++11 constexpr functions and this currently does not work. For now I've reverted this change in r292923. https://reviews.llv

[PATCH] D29063: [libcxx] Never use within libc++

2017-01-24 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath added a comment. Sorry, I meant `-DLIBCXX_ENABLE_ASSERTIONS=ON`. https://reviews.llvm.org/D29063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29063: [libcxx] Never use within libc++

2017-01-24 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath added a comment. @EricWF: My downstream builds have `-DLLVM_ENABLE_ASSERTIONS=ON` by default and they are showing some failures after this commit. Log attached: F3019711: log.txt It should be pretty easy to reproduce these (I'm on Ubuntu 16.04) if yo

[PATCH] D29063: [libcxx] Never use within libc++

2017-01-23 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: include/__config:827 # endif +# if !defined(_LIBCPP_BUILDING_LIBRARY) # define _LIBCPP_EXTERN_TEMPLATE(...) mclow.lists wrote: > Does this belong here? > Yeah, so `-DLIBCXX_ENABLE_ASSERTIONS=ON` now define `-D_LIBC

[PATCH] D29063: [libcxx] Never use within libc++

2017-01-23 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. this LGTM. assert is not something we should have in the dylib. Comment at: include/__config:827 # endif +# if !defined(_LIBCPP_BUILDING_LIBRARY) # define _

[PATCH] D29063: [libcxx] Never use within libc++

2017-01-23 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. Herald added a subscriber: mgorny. It is my opinion that libc++ should never use ``, including in the `dylib`. This patch remove all uses of `assert` from within libc++ and replaces most of them with `_LIBCPP_ASSERT` instead. Additionally this patch turn `LIBCXX_EN