dim abandoned this revision.
dim added a comment.
Ok, back to Mozilla we go.
https://reviews.llvm.org/D28981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF resigned from this revision.
EricWF added a comment.
I think we've agreed that this change shouldn't proceed. Resigning as reviewer.
https://reviews.llvm.org/D28981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
jwakely added a comment.
The __throw_xxx functions are not part of the public libstdc++ API and whatever
Firefox is trying to do with them is not supported by libstdc++ and is
undefined behaviour. Make it stop.
https://reviews.llvm.org/D28981
___
mclow.lists added a comment.
> It would be nice to have some way of making them semi-compatible.
I'm afraid I disagree. If we make them something that people can "count on",
then we have to support them.
The whole point of names that start with `__` (or `_[A-Z]` are that they are
internal, imp
dim added a comment.
In https://reviews.llvm.org/D28981#653908, @mclow.lists wrote:
> > In https://reviews.llvm.org/rL279744, __throw_XXX() functions were
> > introduced, partially for compatibility with software compiled against
> > libstdc++.
>
> You're working from a false premise. These fu
mclow.lists added a comment.
> In https://reviews.llvm.org/rL279744, __throw_XXX() functions were
> introduced, partially for compatibility with software compiled against
> libstdc++.
You're working from a false premise. These functions were not added for
compatibility with libstdc++, but rat
dim created this revision.
In https://reviews.llvm.org/rL279744, `__throw_XXX()` functions were
introduced, partially for compatibility with software compiled against
libstdc++. `_LIBCPP_NORETURN` is used on all of them, and when C++11
attributes are available, this gets defined as `[[noreturn
