This revision was automatically updated to reflect the committed changes.
Closed by commit rL293043: [analyzer] Fix MacOSXAPIChecker fp with static
locals seen from nested blocks. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D28946?vs=85588&id=85722#toc
Repository
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM with some minor comments.
Comment at: lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp:98
+const VarDecl *VD = VR->getDecl();
+// FIXME: These should have
NoQ updated this revision to Diff 85588.
NoQ added a comment.
Reopening due to a revert.
This time i reduce the scope of the fix to the checker, and add FIXMEs to the
problems that showed up while testing it.
https://reviews.llvm.org/D28946
Files:
lib/StaticAnalyzer/Checkers/MacOSXAPIChecke
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292800: [analyzer] Fix memory space of static locals seen
from nested blocks. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D28946?vs=85123&id=85408#toc
Repository:
rL LL
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM!
It would be good to get this into the clang 4.0 svn branch, too. I think Hans
Wennborg is managing this. See
http://clang-developers.42468.n3.nabble.com/4-0-0-Release-The-branch-i
NoQ created this revision.
When a block that is being analyzed as top-level captures static local
variables declared in a function (which itself is not being analyzed)
surrounding the block, it puts such variables into the unknown memory space,
similarly to the stack locals of those functions (
