Anastasia closed this revision.
Anastasia added a comment.
Committed in r293050!
https://reviews.llvm.org/D28860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D28860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
svenvh added a comment.
In https://reviews.llvm.org/D28860#653662, @yaxunl wrote:
> The tests should be added to SemaOpenCL/extension-version.cl
SemaOpenCL/extension-version.cl already has a test for the
cl_khr_3d_image_writes extension.
Comment at: lib/Sema/SemaType.cpp:66
svenvh updated this revision to Diff 85575.
svenvh edited the summary of this revision.
svenvh added a comment.
Removed the custom sema check and added the extension to the image type in
OpenCLImageTypes.def.
https://reviews.llvm.org/D28860
Files:
include/clang/Basic/OpenCLImageTypes.def
l
yaxunl added a comment.
The tests should be added to SemaOpenCL/extension-version.cl
Comment at: lib/Sema/SemaType.cpp:6683
+ // access qualifier unless the cl_khr_3d_image_writes extension is enabled.
+ if (CurType->isOCLImage3dWOType() &&
+ !S.getOpenCLOptions().isEnab
svenvh created this revision.
Prior to OpenCL 2.0, image3d_t can only be used with the write_only
access qualifier when the cl_khr_3d_image_writes extension is enabled.
Clang did not diagnose write_only image3d arguments when the extension
was disabled.
Guard uses of write_only image3d in the Ope
