This revision was automatically updated to reflect the committed changes.
Closed by commit rL292662: IRGen: Start using the WriteThinLTOBitcode pass.
(authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D28843?vs=84907&id=85198#toc
Repository:
rL LLVM
https://reviews.llvm.or
pcc updated this revision to Diff 84907.
pcc added a comment.
Herald added a subscriber: mgorny.
- Add missing test dependency
https://reviews.llvm.org/D28843
Files:
clang/lib/CodeGen/BackendUtil.cpp
clang/test/CMakeLists.txt
clang/test/CodeGenCXX/type-metadata-thinlto.cpp
Index: clang/
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D28843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
pcc updated this revision to Diff 84903.
pcc added a comment.
Refresh
https://reviews.llvm.org/D28843
Files:
clang/lib/CodeGen/BackendUtil.cpp
clang/test/CodeGenCXX/type-metadata-thinlto.cpp
Index: clang/test/CodeGenCXX/type-metadata-thinlto.cpp
===
pcc added inline comments.
Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2
+// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden
-emit-llvm-bc -o %t %s
+// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s
+
tejo
tejohnson added inline comments.
Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2
+// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden
-emit-llvm-bc -o %t %s
+// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s
+
---
mehdi_amini added inline comments.
Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2
+// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden
-emit-llvm-bc -o %t %s
+// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s
+
-
tejohnson added inline comments.
Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2
+// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden
-emit-llvm-bc -o %t %s
+// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s
+
---
mehdi_amini added inline comments.
Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2
+// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden
-emit-llvm-bc -o %t %s
+// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s
+
-
pcc added inline comments.
Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2
+// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden
-emit-llvm-bc -o %t %s
+// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s
+
mehd
mehdi_amini added inline comments.
Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2
+// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden
-emit-llvm-bc -o %t %s
+// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s
+
-
pcc added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:694
+else
+ PerModulePasses.add(
+ createBitcodeWriterPass(*OS, CodeGenOpts.EmitLLVMUseLists));
tejohnson wrote:
> Can we transform other callers of createBitcodeWriterPass
mehdi_amini added inline comments.
Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2
+// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden
-emit-llvm-bc -o %t %s
+// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s
+
-
mehdi_amini added a comment.
In https://reviews.llvm.org/D28843#649207, @tejohnson wrote:
> > TODO: avoid breaking Darwin.
>
> How does this break Darwin?
IIUC, we don't use the new LTO API, which is handling this gracefully.
https://reviews.llvm.org/D28843
tejohnson added a comment.
> TODO: avoid breaking Darwin.
How does this break Darwin?
Comment at: clang/lib/CodeGen/BackendUtil.cpp:694
+else
+ PerModulePasses.add(
+ createBitcodeWriterPass(*OS, CodeGenOpts.EmitLLVMUseLists));
Can we transfo
pcc created this revision.
This is the final change necessary to support CFI with ThinLTO.
TODO: avoid breaking Darwin.
Depends on https://reviews.llvm.org/D28840
https://reviews.llvm.org/D28843
Files:
clang/lib/CodeGen/BackendUtil.cpp
clang/test/CodeGenCXX/type-metadata-thinlto.cpp
Inde
16 matches
Mail list logo
