[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL292374: [OpenMP] Codegen support for 'target parallel' on the host. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D28753?vs=84689&id=84832#toc Repository: rL LLVM https://r

Re: [PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-18 Thread Alexey Bataev via cfe-commits
Armpit, fine, leave it as is Best regards, Alexey Bataev > 18 янв. 2017 г., в 15:50, Arpith Jacob via Phabricator > написал(а): > > arpith-jacob added inline comments. > > > > Comment at: lib/Sema/SemaOpenMP.cpp:1933-1937 > + StmtResult SR = S; > + int ThisCaptureLevel = >

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-18 Thread Arpith Jacob via Phabricator via cfe-commits
arpith-jacob added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:1933-1937 + StmtResult SR = S; + int ThisCaptureLevel = + getOpenMPCaptureLevels(DSAStack->getCurrentDirective()); + while (--ThisCaptureLevel >= 0) +SR = ActOnCapturedRegionEnd(SR.get()); ---

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-18 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with nits Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:848-860 +const StringRef outlinedHelperName, const RegionCodeGenTy &CodeGen) { assert(ThreadIDVar->getType()

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-17 Thread Arpith Jacob via Phabricator via cfe-commits
arpith-jacob updated this revision to Diff 84689. arpith-jacob added a comment. The patch was updated to split 'emitParallelOrTeamsOutlinedFunction' into 'emitParallelOutlinedFunction' and 'emitTeamsOutlinedFunction' to enable the use of getCapturedStmt(). Also updated an assert statement for c

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-17 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:543 virtual llvm::Value *emitParallelOrTeamsOutlinedFunction( - const OMPExecutableDirective &D, const VarDecl *ThreadIDVar, - OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &CodeGen);

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-17 Thread Arpith Jacob via Phabricator via cfe-commits
arpith-jacob added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:543 virtual llvm::Value *emitParallelOrTeamsOutlinedFunction( - const OMPExecutableDirective &D, const VarDecl *ThreadIDVar, - OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &Code

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-17 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:543 virtual llvm::Value *emitParallelOrTeamsOutlinedFunction( - const OMPExecutableDirective &D, const VarDecl *ThreadIDVar, - OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &CodeGen);

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-16 Thread Arpith Jacob via Phabricator via cfe-commits
arpith-jacob updated this revision to Diff 84629. arpith-jacob added a comment. Updated 'getOpenMPCaptureRegions' to return the OMPD_teams region kind for the teams directive. https://reviews.llvm.org/D28753 Files: include/clang/AST/StmtOpenMP.h include/clang/Basic/OpenMPKinds.h include/

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-16 Thread Arpith Jacob via Phabricator via cfe-commits
arpith-jacob updated this revision to Diff 84627. arpith-jacob added a comment. Added a method 'getCapturedStmt' as part of OMPExecutableDirective. https://reviews.llvm.org/D28753 Files: include/clang/AST/StmtOpenMP.h include/clang/Basic/OpenMPKinds.h include/clang/Sema/Sema.h lib/Basic

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-16 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: include/clang/Sema/Sema.h:8328-8330 + /// Return the number of captured regions created for an OpenMP directive. + static int getOpenMPCaptureLevels(OpenMPDirectiveKind Kind); + I think it would be good to have a membe

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

2017-01-15 Thread Arpith Jacob via Phabricator via cfe-commits
arpith-jacob created this revision. arpith-jacob added reviewers: ABataev, sfantao, carlo.bertolli, caomhin, kkwli0, gtbercea. arpith-jacob added a subscriber: cfe-commits. Herald added a subscriber: jholewinski. This patch adds support for codegen of 'target parallel' on the host. It is also the