[PATCH] D28590: [Sema] Restrict explicit instantation definition dllexport

2017-01-12 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL291877: [Sema] Restrict explicit instantation definition dllexport (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D28590?vs=84062&id=84202#toc Repository: rL LLVM https://r

[PATCH] D28590: [Sema] Restrict explicit instantation definition dllexport

2017-01-12 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks for the fix! https://reviews.llvm.org/D28590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D28590: [Sema] Restrict explicit instantation definition dllexport

2017-01-11 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. smeenai added reviewers: hans, rnk. smeenai added subscribers: cfe-commits, steveire. In the case where the template class itself is already `dllexport`, the implicit instantiation will have already emitted all members. When we check the explicit instantiation defini