[PATCH] D28505: CGDecl: Skip static variable initializers in unreachable code

2017-01-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL291576: CGDecl: Skip static variable initializers in unreachable code (authored by matze). Changed prior to commit: https://reviews.llvm.org/D28505?vs=83754&id=83820#toc Repository: rL LLVM https://

[PATCH] D28505: CGDecl: Skip static variable initializers in unreachable code

2017-01-09 Thread Richard Smith via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Yes, this is correct; per [stmt.dcl]/5, the destructor only runs if the object was constructed. Repository: rL LLVM https://reviews.llvm.org/D28505 _

[PATCH] D28505: CGDecl: Skip static variable initializers in unreachable code

2017-01-09 Thread Matthias Braun via Phabricator via cfe-commits
MatzeB created this revision. MatzeB added a reviewer: rsmith. MatzeB added a subscriber: cfe-commits. MatzeB set the repository for this revision to rL LLVM. Herald added a subscriber: mcrosier. This fixes http://llvm.org/PR31054 I don't know whether that is the correct fix: Are we actually allo