This revision was automatically updated to reflect the committed changes.
Closed by commit rL294683: Check for musl-libc's max_align_t in addition to
other variants. (authored by dlj).
Changed prior to commit:
https://reviews.llvm.org/D28478?vs=83681&id=87925#toc
Repository:
rL LLVM
https:/
dlj added a comment.
In https://reviews.llvm.org/D28478#672959, @EricWF wrote:
> IDK how to meaningly test this though.
Heh. Well... I can tell you that with this change (and a couple of others), I'm
able to bootstrap Clang (2-stage) using libc++ on Alpine Linux. It totally
works, I promise!
EricWF added a comment.
IDK how to meaningly test this though.
https://reviews.llvm.org/D28478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D28478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
chandlerc added a reviewer: EricWF.
chandlerc added a comment.
This seems good to me. Check with Eric to see if we try to test this any any
specific way?
https://reviews.llvm.org/D28478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
dlj added a comment.
Ping?
https://reviews.llvm.org/D28478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dlj created this revision.
dlj added a reviewer: mclow.lists.
dlj added a subscriber: cfe-commits.
Libcxx will define its own max_align_t when it is not available. However, the
availability checks today only check for Clang's definition and GCC's
definition. In particular, it does not check for mu
