compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
This is a really nice cleanup!
https://reviews.llvm.org/D28426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
EricWF added a comment.
In https://reviews.llvm.org/D28426#638596, @smeenai wrote:
> I'm guessing always defining `_LIBCPP_DISABLE_MACRO_CONFLICT_WARNINGS` on
> Windows isn't considered an acceptable workaround either?
Not really, since that still breaks users of the `__deallocate` since we
`
smeenai added a comment.
I'm guessing always defining `_LIBCPP_DISABLE_MACRO_CONFLICT_WARNINGS` on
Windows isn't considered an acceptable workaround either?
https://reviews.llvm.org/D28426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
EricWF created this revision.
EricWF added reviewers: compnerd, smeenai, mclow.lists, majnemer, rnk, rsmith.
EricWF added a subscriber: cfe-commits.
On Windows the identifier `__deallocate` is defined as a macro by one of the
Windows system headers. Previously libc++ worked around this by `#undef
