[PATCH] D28407: Refer to _LIBCPP_MSVC macro where applicable

2017-02-05 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r294171 https://reviews.llvm.org/D28407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28407: Refer to _LIBCPP_MSVC macro where applicable

2017-01-06 Thread Dave Lee via Phabricator via cfe-commits
kastiglione updated this revision to Diff 83400. kastiglione added a comment. Revert change to Google Benchmark https://reviews.llvm.org/D28407 Files: include/__config include/__undef___deallocate include/__undef_min_max include/ext/hash_map include/ext/hash_set src/exception.cpp

[PATCH] D28407: Refer to _LIBCPP_MSVC macro where applicable

2017-01-06 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Although Ironically we can no longer support MSVC due to our use of `#include_next` which MSVC doesn't support. Comment at: utils/google-benchmark/include/benchmark/ma

[PATCH] D28407: Refer to _LIBCPP_MSVC macro where applicable

2017-01-06 Thread Dave Lee via Phabricator via cfe-commits
kastiglione created this revision. kastiglione added reviewers: mclow.lists, EricWF, compnerd, smeenai. kastiglione added a subscriber: cfe-commits. Replace preprocess conditions of `defined(_MSC_VER) && !defined(__clang__)` with `defined(_LIBCPP_MSVC)`. No functional change. https://reviews.ll