This revision was automatically updated to reflect the committed changes.
dylanmckay marked an inline comment as done.
Closed by commit rL294177: [AVR] Allow specifying the CPU on the command line
(authored by dylanmckay).
Changed prior to commit:
https://reviews.llvm.org/D28346?vs=87172&id=871
asl accepted this revision.
asl added a comment.
This revision is now accepted and ready to land.
LGTM with minor style nit
Comment at: lib/Basic/Targets.cpp:8733
+ auto It = std::find_if(AVRMcus.begin(),
+AVRMcus.end(),
+[&](const MCUInfo &Info) { return I
dylanmckay marked 2 inline comments as done.
dylanmckay added inline comments.
Comment at: test/CodeGen/avr/target-cpu-defines/atmega328p.c:1
+// RUN: %clang_cc1 -triple avr-unknown-unknown -target-cpu atmega328p
-emit-llvm %s -o - | FileCheck %s
+
asl wrote:
>
dylanmckay updated this revision to Diff 87172.
dylanmckay added a comment.
Clean up the tests
- Dump all defines and search for specific ones
- Remove some unrelated tests. I will commit them separately, as they don't
actually test any behaviour modified in this change.
https://reviews.llvm.o
asl added inline comments.
Comment at: test/CodeGen/avr/target-cpu-defines/atmega328p.c:1
+// RUN: %clang_cc1 -triple avr-unknown-unknown -target-cpu atmega328p
-emit-llvm %s -o - | FileCheck %s
+
This looks wrong. How you're using FileCheck? Consider dumping pr
dylanmckay added a comment.
Ping
https://reviews.llvm.org/D28346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dylanmckay updated this revision to Diff 83496.
dylanmckay added a comment.
Add tests
This also defines the '__AVR' and 'AVR' values for all devices, to match what
AVR-GCC does.
https://reviews.llvm.org/D28346
Files:
lib/Basic/Targets.cpp
test/CodeGen/avr/target-cpu-defines/atmega328p.c
jroelofs added a comment.
Testcase?
https://reviews.llvm.org/D28346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dylanmckay created this revision.
dylanmckay added a reviewer: jroelofs.
dylanmckay added a subscriber: cfe-commits.
This tells clang about all of the different AVR microcontrollers.
It also adds code to define the correct preprocessor macros for each
device.
https://reviews.llvm.org/D28346
Fi
