[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rL294176: [AVR] Add support for the full set of inline asm constraints (authored by dylanmckay). Changed prior to commit: https://reviews.llvm.org/D28344?vs=87191&id=87194#toc Repository: rL LLVM http

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

asl accepted this revision. asl added inline comments. This revision is now accepted and ready to land. Comment at: lib/Basic/Targets.cpp:8570 +} } don't you want to have "return false" here, just to silence warning for some compilers? https://reviews

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

dylanmckay updated this revision to Diff 87191. dylanmckay removed a reviewer: asl. dylanmckay added a comment. Add tests - Add multichar constraint tests - Add 'unsupported constraint' tests https://reviews.llvm.org/D28344 Files: lib/Basic/Targets.cpp test/CodeGen/avr-inline-asm-constrain

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

dylanmckay updated this revision to Diff 87190. dylanmckay marked an inline comment as done. dylanmckay added a comment. Add tests - Add multichar constraint tests - Add 'unsupported constraint' tests https://reviews.llvm.org/D28344 Files: lib/Basic/Targets.cpp test/CodeGen/avr-inline-asm-

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

asl added inline comments. Comment at: test/CodeGen/avr-inline-asm-constraints.c:2 +// REQUIRES: avr-registered-target +// RUN: %clang_cc1 -triple avr-unknown-unknown -emit-llvm -o - %s | FileCheck %s + You need checks for multi-character stuff and unsupported c

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

dylanmckay marked an inline comment as done. dylanmckay added a comment. Ping https://reviews.llvm.org/D28344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

dylanmckay marked an inline comment as done. dylanmckay added a comment. Ping https://reviews.llvm.org/D28344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

dylanmckay marked an inline comment as done. dylanmckay added inline comments. Comment at: lib/Basic/Targets.cpp:8506 + case 'N': // Integer constant (Range: -1) +Info.setRequiresImmediate(-1); + case 'O': // Integer constant (Range: 8, 16, 24)

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

dylanmckay updated this revision to Diff 83507. dylanmckay added a comment. Add tests for inline assembly constraints https://reviews.llvm.org/D28344 Files: lib/Basic/Targets.cpp test/CodeGen/avr-inline-asm-constraints.c Index: test/CodeGen/avr-inline-asm-constraints.c

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

dylanmckay updated this revision to Diff 83504. dylanmckay added a comment. Fix a few cases of unintentional switch fallthrough https://reviews.llvm.org/D28344 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp === --- l

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

ahatanak added a comment. Test case? Comment at: lib/Basic/Targets.cpp:8506 + case 'N': // Integer constant (Range: -1) +Info.setRequiresImmediate(-1); + case 'O': // Integer constant (Range: 8, 16, 24) Is this meant to fall through or do you

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

dylanmckay created this revision. dylanmckay added a reviewer: jroelofs. dylanmckay added subscribers: cfe-commits, saaadhu. Previously the method would simply return false, causing every single inline assembly constraint to trigger a compile error. This adds inline assembly constraint support fo