Re: [PATCH] D28343: [AVR] Fix register numbers for in getGCCAddlRegNames()

2017-01-04 Thread Dylan McKay via cfe-commits
I see, that's a good idea. I'll revert r291083 and we can go forward with this patch. On Thu, Jan 5, 2017 at 8:05 PM, Senthil Kumar Selvaraj via Phabricator < revi...@reviews.llvm.org> wrote: > saaadhu added a comment. > > If you've added X, Y, Z and SP to GCCRegNames, you don't need AddlRegName

[PATCH] D28343: [AVR] Fix register numbers for in getGCCAddlRegNames()

2017-01-04 Thread Senthil Kumar Selvaraj via Phabricator via cfe-commits
saaadhu added a comment. If you've added X, Y, Z and SP to GCCRegNames, you don't need AddlRegNames array at all, The reason I had them in AddlRegNames was to tell Clang that they alias regs in GCCRegNames. I followed X86TargetInfo's example - it has "ax" in GCCRegNames, and "al", "ah", "eax"

[PATCH] D28343: [AVR] Fix register numbers for in getGCCAddlRegNames()

2017-01-04 Thread Dylan McKay via Phabricator via cfe-commits
dylanmckay created this revision. dylanmckay added a reviewer: saaadhu. dylanmckay added a subscriber: cfe-commits. These do not match up with the register numbers defined in LLVM's AVRRegisterInfo.td Adding Senthil as a reviewer as he originally implemented this. https://reviews.llvm.org/D2834