mgorny added a comment.
Oh, sorry that I didn't check that. Then I guess it's good enough for me, we're
losing just few old Athlon 64 CPUs, I guess. I'll update the patch to remove
4.2 only.
https://reviews.llvm.org/D28304
___
cfe-commits mailing
dvyukov added a comment.
> I don't see a big issue enabling it for x86-64 but for 32-bit systems you're
> ruling out quite a lot of hardware.
Tsan does not support 32-bits.
https://reviews.llvm.org/D28304
___
cfe-commits mailing list
cfe-commits@l
mgorny added a comment.
In https://reviews.llvm.org/D28304#636669, @dvyukov wrote:
> User -march flag won't help as runtime is prebuilt.
I meant the flag used by the compiler vendor when compiler-rt is built.
> SCUDO is sse4.2, but tsan is sse3. Do you actually see any problems with
> sse3? I
dvyukov added a comment.
Yes, for tsan runtime detection does not make lots of sense -- we only have few
SSE instructions on inlined fast path. The SSE code provides quite substantial
speedup. User -march flag won't help as runtime is prebuilt. SCUDO is sse4.2,
but tsan is sse3. Do you actually
cryptoad added a comment.
Understood.
I'll let someone else chime on on the TSAN aspect of the patch.
https://reviews.llvm.org/D28304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
In https://reviews.llvm.org/D28304#635620, @cryptoad wrote:
> Hey Michal,
> If I understand correctly, my next move is to move the CRC32 code into it's
> own file an only enable SSE 4.2 for this file?
Yes, like that. Have a SSE4.2 CRC32 function in a separate file, and
cryptoad added a comment.
Hey Michal,
If I understand correctly, my next move is to move the CRC32 code into it's own
file an only enable SSE 4.2 for this file?
Shouldn't COMPILER_RT_HAS_MSSE4_2_FLAG be kept for that purpose or is there an
alternative way to do it?
Thanks
https://reviews.llvm.
mgorny created this revision.
mgorny added reviewers: cryptoad, kcc, samsonov.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: dberris, kubabrecka.
Disable the code appending -msse3 and -msse4.2 flags implicitly when
the compiler supports them. The compiler support for those flag
