mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 319736
https://reviews.llvm.org/D28253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM minus the `config.py` changes, but those were discussed offline.
Also I prefer to write new `.fail.cpp` tests using clang verify. It allows fail
tests to contain more than one test case,
mclow.lists created this revision.
mclow.lists added a reviewer: EricWF.
mclow.lists added a subscriber: cfe-commits.
http://llvm.org/show_bug.cgi?id=28929 shows a scenario where `make_shared` of a
class with a protected constructor compiles successfully (it should fail).
This is because we appl
mclow.lists added inline comments.
Comment at: test/libcxx/test/config.py:415
self.cxx.compile_flags += ['-I' + cxx_headers]
+if self.libcxx_obj_root is None:
+return
Whoops. This change doesn't belong here.
But it fixes a problem run
