[PATCH] D28217: [libc++] Overallocation of am_pm array in locale.cpp

2018-01-11 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. Committed as r322295 https://reviews.llvm.org/D28217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28217: [libc++] Overallocation of am_pm array in locale.cpp

2017-01-03 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. This looks fine to me. All the other places that use this (or related functionality) have a rank of 2. Interestingly enough, this has been there since "the beginning of time" (the initial import of libc++ into the LLVM subversion repo) https://reviews.llvm.org/D2

[PATCH] D28217: [libc++] Overallocation of am_pm array in locale.cpp

2017-01-02 Thread Daniel C. Dillon via Phabricator via cfe-commits
dcdillon created this revision. dcdillon added a reviewer: howard.hinnant. dcdillon added a subscriber: cfe-commits. Herald added a reviewer: EricWF. Changed array size from 24 to 2 in init_am_pm() and init_wam_pm() https://reviews.llvm.org/D28217 Files: src/locale.cpp Index: src/locale.cpp