[PATCH] D28210: system_error: inline error_category ctor on Win32

2017-01-02 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd abandoned this revision. compnerd added a comment. WFM, that seems like a nicer option. Repository: rL LLVM https://reviews.llvm.org/D28210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D28210: system_error: inline error_category ctor on Win32

2017-01-02 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. I committed a different fix for this patch in r290840. Instead of just fixing this on Windows it makes the removal of this definition an ABI option, which it then disables on Windows by default. Repository: rL LLVM https://reviews.llvm.org/D28210 _

[PATCH] D28210: system_error: inline error_category ctor on Win32

2017-01-01 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd created this revision. compnerd added reviewers: EricWF, mclow.lists, majnemer. compnerd added subscribers: smeenai, cfe-commits. compnerd set the repository for this revision to rL LLVM. Because the class is marked as `dllexport` and instantiated in `algorithm.cpp` and is strongly define