thakis closed this revision.
thakis added a comment.
http://llvm.org/viewvc/llvm-project?view=revision&revision=290930
https://reviews.llvm.org/D28165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
danbeam updated this revision to Diff 82989.
danbeam marked an inline comment as done.
danbeam added a comment.
setting up arc
https://reviews.llvm.org/D28165
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
--- li
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
I'd rather we don't deviate from google style at all, but this brings us closer
from where we are to that, so lgtm :-)
https://reviews.llvm.org/D28165
_
danbeam marked an inline comment as done.
danbeam added inline comments.
Comment at: lib/Format/Format.cpp:643
+ChromiumStyle.AllowShortIfStatementsOnASingleLine = false;
+ChromiumStyle.AllowShortLoopsOnASingleLine = false;
+ }
thakis wrote:
> Thanks for
danbeam updated this revision to Diff 82946.
danbeam added a comment.
make a branch specific to JS and duplicate some format options for explicitness
https://reviews.llvm.org/D28165
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
thakis added inline comments.
Comment at: lib/Format/Format.cpp:643
+ChromiumStyle.AllowShortIfStatementsOnASingleLine = false;
+ChromiumStyle.AllowShortLoopsOnASingleLine = false;
+ }
Thanks for the patch! Do we want these as false in Chromium's JS? I w
danbeam created this revision.
danbeam added a reviewer: thakis.
danbeam added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Chromium is starting to use clang-format on more JavaScript.
In doing this, we discovered that our defaults were not doing a good job
differentiating betwe
