[PATCH] D28153: [clang] Fix clean build of generate-order-file

2016-12-30 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL290781: [clang] Fix clean build of generate-order-file (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D28153?vs=82715&id=82755#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D28153: [clang] Fix clean build of generate-order-file

2016-12-29 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D28153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D28153: [clang] Fix clean build of generate-order-file

2016-12-29 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap added inline comments. Comment at: utils/perf-training/CMakeLists.txt:61 +message(FATAL_ERROR "Output clang order file is not set") + endif() + alexshap wrote: > mehdi_amini wrote: > > I'm missing something: the code in the main CMakeLists seems to

[PATCH] D28153: [clang] Fix clean build of generate-order-file

2016-12-29 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap removed rL LLVM as the repository for this revision. alexshap updated this revision to Diff 82715. alexshap added a comment. upd https://reviews.llvm.org/D28153 Files: CMakeLists.txt utils/perf-training/CMakeLists.txt Index: utils/perf-training/CMakeLists.txt

[PATCH] D28153: [clang] Fix clean build of generate-order-file

2016-12-29 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. I mean the two checks being out-of-sync is weird, so I rather have them reconciled. Repository: rL LLVM https://reviews.llvm.org/D28153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D28153: [clang] Fix clean build of generate-order-file

2016-12-29 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap added inline comments. Comment at: CMakeLists.txt:436 + + if(CLANG_ORDER_FILE AND NOT EXISTS ${CLANG_ORDER_FILE}) +string(FIND "${CLANG_ORDER_FILE}" "${CMAKE_CURRENT_BINARY_DIR}" PATH_START) mehdi_amini wrote: > So why `if(CLANG_ORDER_FILE ` here?

[PATCH] D28153: [clang] Fix clean build of generate-order-file

2016-12-29 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added inline comments. Comment at: CMakeLists.txt:436 + + if(CLANG_ORDER_FILE AND NOT EXISTS ${CLANG_ORDER_FILE}) +string(FIND "${CLANG_ORDER_FILE}" "${CMAKE_CURRENT_BINARY_DIR}" PATH_START) So why `if(CLANG_ORDER_FILE ` here? Repository: rL

[PATCH] D28153: [clang] Fix clean build of generate-order-file

2016-12-29 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap added inline comments. Comment at: utils/perf-training/CMakeLists.txt:61 +message(FATAL_ERROR "Output clang order file is not set") + endif() + mehdi_amini wrote: > I'm missing something: the code in the main CMakeLists seems to allows to > have an

[PATCH] D28153: [clang] Fix clean build of generate-order-file

2016-12-29 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added inline comments. Comment at: utils/perf-training/CMakeLists.txt:61 +message(FATAL_ERROR "Output clang order file is not set") + endif() + I'm missing something: the code in the main CMakeLists seems to allows to have an empty value for the

[PATCH] D28153: [clang] Fix clean build of generate-order-file

2016-12-29 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap updated this revision to Diff 82703. alexshap added a comment. minor changes Repository: rL LLVM https://reviews.llvm.org/D28153 Files: CMakeLists.txt utils/perf-training/CMakeLists.txt Index: utils/perf-training/CMakeLists.txt =

[PATCH] D28153: [clang] Fix clean build of generate-order-file

2016-12-28 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap created this revision. alexshap added reviewers: beanz, bogner. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. Herald added a subscriber: mgorny. This diff fixes the clean build of the target generate-order-file. In llvm/tools/clang/CMa