This revision was automatically updated to reflect the committed changes.
Closed by commit rL290983: [OpenMP] Update target codegen for NVPTX device.
(authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D28125?vs=82621&id=83085#toc
Repository:
rL LLVM
https://reviews.llvm
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D28125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
arpith-jacob updated this revision to Diff 82621.
arpith-jacob added a comment.
Alexey and Justin, thank you for spending the time to review this patch. I've
updated the patch accordingly. I've also removed a dot ('.') from the worker
function name since the character is not accepted by the nv
jlebar added a comment.
Apologies for the drive-by review.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.h:30
+ // Private state and methods.
+ //
+
This comment seems redundant with "private:" above?
https://reviews.llvm.org/D28125
__
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:248
+ Address WorkFn = CGF.CreateTempAlloca(
+ CGF.Int8PtrTy, CharUnits::fromQuantity(8), /*Name*/ "work_fn");
+ Address ExecStatus =
I don't like the idea of using absolute nu
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, sfantao, carlo.bertolli, kkwli0, caomhin.
arpith-jacob added a subscriber: cfe-commits.
Herald added subscribers: aprantl, jholewinski.
This patch includes updates for codegen of the target region for the NVPTX
device. It
