This revision was automatically updated to reflect the committed changes.
Closed by commit rL291669: [find-all-symbols] Index partial template
specializations. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D27920?vs=83944&id=83951#toc
Repository:
rL LLVM
https://re
hokein updated this revision to Diff 83944.
hokein marked an inline comment as done.
hokein added a comment.
Fix code style nit.
https://reviews.llvm.org/D27920
Files:
include-fixer/find-all-symbols/FindAllSymbols.cpp
unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
Index:
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
The reason why we disallowed specializations is that there are type-trait
classes that get specialized all over the place (DenseMapInfo in LLVM is one
example). I think we can get away with
ioeric added a comment.
I'm not quite convinced/sure if we want to match all partial specializations
just for `std::function`. We filtered out template specialization because there
could be multiple specializations for a template in different headers and it
was not clear which one we would choo
hokein added a comment.
In https://reviews.llvm.org/D27920#628586, @ioeric wrote:
> Why do we allow partially specialization but fully specialization now? Could
> you elaborate in the cl description?
Done.
https://reviews.llvm.org/D27920
___
cfe
ioeric added a comment.
Why do we allow partially specialization but fully specialization now? Could
you elaborate in the cl description?
https://reviews.llvm.org/D27920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added subscribers: bkramer, cfe-commits.
Fix no std::function index.
https://reviews.llvm.org/D27920
Files:
include-fixer/find-all-symbols/FindAllSymbols.cpp
unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cp
