[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 abandoned this revision. gamesh411 added a comment. Herald added subscribers: Charusso, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. There are multiple new additions to stream formatters, and this patch is way too old. I may consider creating a new che

[PATCH] D27918: [analyzer] OStreamChecker

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/OStreamFormatChecker.cpp:513 + +bool OStreamFormatChecker::evalCall(const CallExpr *CE, +CheckerContext &C) const { gamesh411 wrote: > NoQ wrote: > > One

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 added a comment. Ping. @NoQ would you please have a look? Thanks! https://reviews.llvm.org/D27918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 updated this revision to Diff 107923. https://reviews.llvm.org/D27918 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/OStreamFormatChecker.cpp test/Analysis/Inputs/system-header-simulator-cxx-iostrea

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 updated this revision to Diff 107921. https://reviews.llvm.org/D27918 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/OStreamFormatChecker.cpp test/Analysis/Inputs/system-header-simulator-cxx-iostrea

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 added a comment. Hello, After experimentation the following AST difference between the mock and the standard library implementation still stands (which necessitates the special handling of the complex manipulators). Example: // The different behaviour of the AST is illustrated on t

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 updated this revision to Diff 101549. gamesh411 marked an inline comment as done. gamesh411 added a comment. Update diff. https://reviews.llvm.org/D27918 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checke

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 marked 6 inline comments as done. gamesh411 added a comment. Update diff. Comment at: lib/StaticAnalyzer/Checkers/OStreamFormatChecker.cpp:263-282 + mutable IdentifierInfo *II_BasicOstream, *II_Flags, *II_Setf, *II_Unsetf, + *II_Setiosflags, *II_Resetiosflags, *

[PATCH] D27918: [analyzer] OStreamChecker

NoQ added a comment. Hello, Sorry again for the delays, thank you for your patience. Your checker is in good shape, very well-structured and easy to follow, you definitely know your stuff, and my comments here are relatively minor. Are you planning on making more varied warning messages, eg. s

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 added a comment. Hello, This checker was developed indeed with internal usage in mind. It should not necessary be added as a default checker. However I have run it on the boost-1.63.0 codebase, and there some some mildly interesting findings in examples and tests. There is also a true

[PATCH] D27918: [analyzer] OStreamChecker

NoQ added a comment. Hello, Thanks for the patch, and for the impressing amount of work you put into this. Because the patch is huge, so it's going to take some time for somebody to understand how everything works. I'd probably like to learn a bit more about the motivation behind the checker.