This revision was automatically updated to reflect the committed changes.
Closed by commit rL304813: add missing constexpr to optional::value_or
(authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D27850?vs=82653&id=101597#toc
Repository:
rL LLVM
https://reviews.llv
cpplearner added a comment.
Yes, I do. Thank you.
https://reviews.llvm.org/D27850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
@cpplearner Do you need somebody to commit this for you?
https://reviews.llvm.org/D27850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cpplearner updated this revision to Diff 82653.
cpplearner added a comment.
backed out the changes to ``
https://reviews.llvm.org/D27850
Files:
include/optional
test/std/utilities/optional/optional.object/optional.object.observe/value_or.pass.cpp
Index:
test/std/utilities/optional/optio
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
The changes to `` LGTM but not the ones to ``
Unfortunately libc++'s `` doesn't yet implement LFTS v2
so all of the other non-const observers are also not constexpr in our
implementation. I t
cpplearner updated this revision to Diff 82551.
https://reviews.llvm.org/D27850
Files:
include/experimental/optional
include/optional
test/std/experimental/optional/optional.object/optional.object.observe/value_or.pass.cpp
test/std/utilities/optional/optional.object/optional.object.obse
cpplearner updated this revision to Diff 82549.
cpplearner added a comment.
test updated
https://reviews.llvm.org/D27850
Files:
test/std/utilities/optional/optional.object/optional.object.observe/value_or.pass.cpp
Index:
test/std/utilities/optional/optional.object/optional.object.observe/
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Tests please! They should be somewhere under
`test/std/utilities/optional/optional.object/optional.object.observe`
https://reviews.llvm.org/D27850
___
cpplearner created this revision.
cpplearner added reviewers: mclow.lists, EricWF, howard.hinnant.
cpplearner added a subscriber: cfe-commits.
See https://github.com/cplusplus/draft/pull/839 and
https://github.com/cplusplus/fundamentals-ts/pull/73.
https://reviews.llvm.org/D27850
Files:
incl
