jordan_rose accepted this revision.
jordan_rose added a reviewer: jordan_rose.
jordan_rose added a comment.
This revision is now accepted and ready to land.
Doug was okay with the idea and I trust Alex and Akira would have caught any
major problems. Committed in r290132.
Repository:
rL LLVM
jordan_rose updated this revision to Diff 81796.
jordan_rose added a comment.
Updated names to match LLVM style.
Repository:
rL LLVM
https://reviews.llvm.org/D27837
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaType.cpp
test/FixIt/Inputs/nullability.h
test/FixIt/null
ahatanak added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8772
+def note_nullability_fix_it : Note<
+ "insert '%select{_Nonnull|_Nullable|_Null_unspecified}0' if the "
+ "%select{pointer|block pointer|member pointer|array parameter}1 "
-
jordan_rose added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8772
+def note_nullability_fix_it : Note<
+ "insert '%select{_Nonnull|_Nullable|_Null_unspecified}0' if the "
+ "%select{pointer|block pointer|member pointer|array parameter}1 "
--
ahatanak added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8772
+def note_nullability_fix_it : Note<
+ "insert '%select{_Nonnull|_Nullable|_Null_unspecified}0' if the "
+ "%select{pointer|block pointer|member pointer|array parameter}1 "
-
arphaman added inline comments.
Comment at: lib/Sema/SemaType.cpp:3491
+/// taking into account whitespace before and after.
+static FixItHint fixItNullability(Sema &S, SourceLocation pointerLoc,
+ NullabilityKind nullability) {
N
jordan_rose created this revision.
jordan_rose added a reviewer: doug.gregor.
jordan_rose added a subscriber: cfe-commits.
jordan_rose set the repository for this revision to rL LLVM.
This is especially important for arrays, since no one knows the proper syntax
for putting qualifiers in arrays.
