[PATCH] D27785: [libcxx] [test] Fix recently introduced warnings emitted by MSVC.

2016-12-23 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. `-Wsign-compare` has also landed :-) Now just `-Wconversion` to go (but that will likely take a while). https://reviews.llvm.org/D27785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D27785: [libcxx] [test] Fix recently introduced warnings emitted by MSVC.

2016-12-23 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. Alright. The unused parameter parts of this patch are no longer needed. `-Wunused-parameter` and `-Wunused-variable` have been enabled within libc++. Just working on `-Wsign-compare` now. https://reviews.llvm.org/D27785 ___

[PATCH] D27785: [libcxx] [test] Fix recently introduced warnings emitted by MSVC.

2016-12-23 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Sorry about that. I'm working to turn on -Wunused-parameter and others to avoid these issues. https://reviews.llvm.org/D27785 ___ cfe-commits ma

[PATCH] D27785: [libcxx] [test] Fix recently introduced warnings emitted by MSVC.

2016-12-14 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix recently introduced warnings emitted by MSVC. test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_pair_const_lvalue_pair.pass.cpp test/